Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 | # SPDX-License-Identifier: GPL-2.0+ # Copyright (c) 2011 The Chromium OS Authors. # import collections import os import re import sys from patman import command from patman import gitutil from patman import terminal from patman import tools def FindCheckPatch(): top_level = gitutil.GetTopLevel() try_list = [ os.getcwd(), os.path.join(os.getcwd(), '..', '..'), os.path.join(top_level, 'tools'), os.path.join(top_level, 'scripts'), '%s/bin' % os.getenv('HOME'), ] # Look in current dir for path in try_list: fname = os.path.join(path, 'checkpatch.pl') if os.path.isfile(fname): return fname # Look upwwards for a Chrome OS tree while not os.path.ismount(path): fname = os.path.join(path, 'src', 'third_party', 'kernel', 'files', 'scripts', 'checkpatch.pl') if os.path.isfile(fname): return fname path = os.path.dirname(path) sys.exit('Cannot find checkpatch.pl - please put it in your ' + '~/bin directory or use --no-check') def CheckPatch(fname, verbose=False, show_types=False): """Run checkpatch.pl on a file. Args: fname: Filename to check verbose: True to print out every line of the checkpatch output as it is parsed show_types: Tell checkpatch to show the type (number) of each message Returns: namedtuple containing: ok: False=failure, True=ok problems: List of problems, each a dict: 'type'; error or warning 'msg': text message 'file' : filename 'line': line number errors: Number of errors warnings: Number of warnings checks: Number of checks lines: Number of lines stdout: Full output of checkpatch """ fields = ['ok', 'problems', 'errors', 'warnings', 'checks', 'lines', 'stdout'] result = collections.namedtuple('CheckPatchResult', fields) result.ok = False result.errors, result.warnings, result.checks = 0, 0, 0 result.lines = 0 result.problems = [] chk = FindCheckPatch() item = {} args = [chk, '--no-tree'] if show_types: args.append('--show-types') result.stdout = command.Output(*args, fname, raise_on_error=False) #pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE) #stdout, stderr = pipe.communicate() # total: 0 errors, 0 warnings, 159 lines checked # or: # total: 0 errors, 2 warnings, 7 checks, 473 lines checked emacs_prefix = '(?:[0-9]{4}.*\.patch:[0-9]+: )?' emacs_stats = '(?:[0-9]{4}.*\.patch )?' re_stats = re.compile(emacs_stats + 'total: (\\d+) errors, (\d+) warnings, (\d+)') re_stats_full = re.compile(emacs_stats + 'total: (\\d+) errors, (\d+) warnings, (\d+)' ' checks, (\d+)') re_ok = re.compile('.*has no obvious style problems') re_bad = re.compile('.*has style problems, please review') type_name = '([A-Z_]+:)?' re_error = re.compile('ERROR:%s (.*)' % type_name) re_warning = re.compile(emacs_prefix + 'WARNING:%s (.*)' % type_name) re_check = re.compile('CHECK:%s (.*)' % type_name) re_file = re.compile('#\d+: FILE: ([^:]*):(\d+):') re_note = re.compile('NOTE: (.*)') indent = ' ' * 6 for line in result.stdout.splitlines(): if verbose: print(line) # A blank line indicates the end of a message if not line: if item: result.problems.append(item) item = {} continue if re_note.match(line): continue # Skip lines which quote code if line.startswith(indent): continue # Skip code quotes and #<n> if line.startswith('+') or line.startswith('#'): continue match = re_stats_full.match(line) if not match: match = re_stats.match(line) if match: result.errors = int(match.group(1)) result.warnings = int(match.group(2)) if len(match.groups()) == 4: result.checks = int(match.group(3)) result.lines = int(match.group(4)) else: result.lines = int(match.group(3)) continue elif re_ok.match(line): result.ok = True continue elif re_bad.match(line): result.ok = False continue err_match = re_error.match(line) warn_match = re_warning.match(line) file_match = re_file.match(line) check_match = re_check.match(line) subject_match = line.startswith('Subject:') if err_match: item['cptype'] = err_match.group(1) item['msg'] = err_match.group(2) item['type'] = 'error' elif warn_match: item['cptype'] = warn_match.group(1) item['msg'] = warn_match.group(2) item['type'] = 'warning' elif check_match: item['cptype'] = check_match.group(1) item['msg'] = check_match.group(2) item['type'] = 'check' elif file_match: item['file'] = file_match.group(1) item['line'] = int(file_match.group(2)) elif subject_match: item['file'] = '<patch subject>' item['line'] = None else: print('bad line "%s", %d' % (line, len(line))) return result def GetWarningMsg(col, msg_type, fname, line, msg): '''Create a message for a given file/line Args: msg_type: Message type ('error' or 'warning') fname: Filename which reports the problem line: Line number where it was noticed msg: Message to report ''' if msg_type == 'warning': msg_type = col.Color(col.YELLOW, msg_type) elif msg_type == 'error': msg_type = col.Color(col.RED, msg_type) elif msg_type == 'check': msg_type = col.Color(col.MAGENTA, msg_type) line_str = '' if line is None else '%d' % line return '%s:%s: %s: %s\n' % (fname, line_str, msg_type, msg) def CheckPatches(verbose, args): '''Run the checkpatch.pl script on each patch''' error_count, warning_count, check_count = 0, 0, 0 col = terminal.Color() for fname in args: result = CheckPatch(fname, verbose) if not result.ok: error_count += result.errors warning_count += result.warnings check_count += result.checks print('%d errors, %d warnings, %d checks for %s:' % (result.errors, result.warnings, result.checks, col.Color(col.BLUE, fname))) if (len(result.problems) != result.errors + result.warnings + result.checks): print("Internal error: some problems lost") for item in result.problems: sys.stderr.write( GetWarningMsg(col, item.get('type', '<unknown>'), item.get('file', '<unknown>'), item.get('line', 0), item.get('msg', 'message'))) print #print(stdout) if error_count or warning_count or check_count: str = 'checkpatch.pl found %d error(s), %d warning(s), %d checks(s)' color = col.GREEN if warning_count: color = col.YELLOW if error_count: color = col.RED print(col.Color(color, str % (error_count, warning_count, check_count))) return False return True |